Hi,

Some feedback while trying to implement these XEPs

XEP-0424

1)

The schema mentions

<xs:attribute name='by' type='xs:string' use='optional'/>

But the XEP does not mention the attribute, what is the purpose?

2)

> When replacing the original message with a tombstone, the original contents (i.e. the <body/> and any related elements which might leak information about the original message) get replaced with a <retracted/> element which MUST include an 'id' attribute referring to the original message

Why does the element MUST have an id attribute? its a element inside the <message> which already has the id, or in case of groupchat its inside a mam wrapper which has a stanza id, in all cases its perfectly clear that the retracted element belongs to the actual message wrapping it, maybe im missing something obvious here but i dont see a need for this id attribute at all.

Example 7

> For messages of type 'groupchat', the stanza's Unique and Stable Stanza IDs (XEP-0359) [4] 'origin ID' MUST NOT be used for retractions

Example mentions origin-id in groupchat context

XEP-0425

1)

> A Message Archive Management (XEP-0313) [6] service MAY replace the contents of a message, that was retracted due to moderation, with a 'tombstone' similar to the one described in Message Retraction (XEP-0424) [5].

How similiar? The tombstone text does not mention seemingly important MUST rules from XEP 0424

For example

> Some clients may have been offline while the retraction was issued. The archiving service therefore MUST store the retraction message, regardless of whether the original message is deleted or replaced with a tombstone.

the above mentioned MUST rule about the id attribute in the <retracted> element, seems to be not important anymore in moderation, at least the id attribute is not found anymore in the tombstone.

Im not saying we need to copy text 1:1 between the XEPs, but should the XEP not go into more detail what exactly the differences are, and what exactly from 0424 applies?

Thanks

Regards

Philipp