[JDEV] secret for dialback

Robert Norris rob at cataclysm.cx
Mon Jan 20 20:40:34 CST 2003


> I just noticed that there is a dialback secret, which is a child tag in 
> my config file. But dialback.so entry point does this
> 
> d->secret = xmlnode_get_attrib(cfg,"secret");
> 
> looking for an attribute. Secret just feels a lot more like a child tag. 
> Changing the code to
> 
> d->secret = pstrdup(i->p,xmlnode_get_tag_data(cfg,"secret"));

Yes, I'd say that was what it was supposed to be. Although I'd suggest:

d->secret = xmlnode_get_tag_data(cfg, "secret");

No need to copy it, since the server config xmlnode never gets
deallocated.

Rob.

-- 
Robert Norris                                       GPG: 1024D/FC18E6C2
Email+Jabber: rob at cataclysm.cx                Web: http://cataclysm.cx/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.jabber.org/pipermail/jdev/attachments/20030121/acf57568/attachment-0002.pgp>


More information about the JDev mailing list