3 Dec
2024
3 Dec
'24
5:43 a.m.
Le 26/11/2024 à 21:37, Goffi a écrit :
Hello,
thank you for your contribution! This is a useful feature and we can
appreciate the effort put in this protoXEP.
Thanks a lot!
I made a PR with the requested modifications:
https://github.com/xsf/xeps/pull/1404
Some notes beneath:
- Glossary redefines many terms from XEP-0045. There
is no need for that, it
makes the specification more difficult to read, and it duplicates information.
Just add a note to reference XEP-0045.
I added a paragraph in the Glossary section, saying:
Many terms used in this XEP are defined in
&xep0045; and &xep0128;. Please refer to these XEP for more informations.
Is this correct?
Or is this redundant with the <dependencies> section?
- In
https://xmpp.org/extensions/inbox/xep-slow-mode.html#example-1 there is a
confusion between label and description. Label should be a simple "Slow
Mode",
and <desc> should be used for the description (cf. https://xmpp.org/
extensions/xep-0004.html#protocol-field). It's just an example, but if
developer copy it, it will result in bad UX for end-users.
Right.
I tested it so in my first implementation, but it did not work at the
time...
It was ConverseJS that was ignoring the <desc> child node.
This was fixed in ConverseJS, but i forgot to change my implementation
(and the xep).
Thanks!
Other points were fixed.
--
John