Hi!
Thanks for the (quick) feedback !
My answers bellow:
Le 30/06/2025 à 14:26, Peter Saint-Andre a écrit :
Hi Timothée, thanks for working on this. Comments
inline.
On 6/30/25 4:16 AM, Timothée Jaussoin wrote:
A few weeks ago I made an important pull request
to complete, fix and
update the XEP-0317: Hats.
https://github.com/xsf/xeps/pull/1437
This PR included the following changes:
* Specify a urn:xmpp:hats:commands:dcreate command to add a hat to the
available list
* Specify a urn:xmpp:hats:commands:ddestroy command to destroy a hat
from the list
* Clarify how the service should broadcast the hat changes when it is
edited, assigned, removed or destroyed
* Specify a way for an entity to get the complete list of hats using a
hash in disco#info
* Add a hue optional parameter allowing entities to assign a color to
the hat that can be displayed properly in any conditions on the
client (as explained in XEP-0392: Consistent Color Generation)
* Standardize all the form fields using XEP-0068
* Fix some typos
Overall these changes seem reasonable.
I have a few questions:
How are clients supposed to process the hash of supported hats, given
that the hash-calculation method is implementation-specific? It seems
that the client needs to cache the hash, then retrieve the list of
hats if the hashes don't match. Is that all?
Yes, I could add a section that
enforce a specific hash-calculation, but
as a client developer caching seems "good enough" to me.
When a hat is destroyed, are participants who had that hat informed?
I have this small paragraph to cover that case:
/The service SHOULD broadcast the related JID presences with the
refreshed hats list./
I tried to reach the authors without success so
I'm trying again
using the mailing list.
This puzzles me. If you ever need to ping me on GitHub, just flag
@stpeter - and I would think that Matthew is very easy to find in
chatrooms etc.
Indeed I didn't pinged you on GitHub, only tried to reach you on
XMPP :)
Next time I'll do it this way.
I'd really like to move it forward then we
can start implementing
them in our clients and servers.
Sounds great.
For historical purposes, you might find it interesting that my
original motivation for defining Hats was to support in XMPP some of
the features that existed in WebEx (I worked on the WebEx team at that
time). It's interesting to me that such features are still useful. :-)
Interesting indeed, on my side I have lots of nice ideas around hats in
Movim, this XEP PR will help a lot for sure :)
Peter